Feat : 대학/학과 공지 뷰 api 연결 및 무한 스크롤 적용 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwoo-jo
requested changes
Feb 23, 2024
app/src/main/java/com/dongyang/android/youdongknowme/data/repository/NoticeRepository.kt
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/standard/network/RetrofitObject.kt
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/notice/NoticeFragment.kt
Show resolved
Hide resolved
Comment on lines
-109
to
-118
| override fun onResume() { | ||
| super.onResume() | ||
| val intentFilter = IntentFilter(ACTION.FCM_ACTION_NAME) | ||
| LocalBroadcastManager.getInstance(requireContext()) | ||
| .registerReceiver(localBroadCast, intentFilter) | ||
| } | ||
|
|
||
| override fun onStop() { | ||
| super.onStop() | ||
| LocalBroadcastManager.getInstance(requireContext()).unregisterReceiver(localBroadCast) |
There was a problem hiding this comment.
단순 궁금증 : 이 파트가 왜 지워진건지 궁금합니당
There was a problem hiding this comment.
Fcm 관련 코드인 것 같아서 지웠는데 fcm 제가 구현해보고 싶어서요 ㅎㅅㅎ
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/notice/NoticeFragment.kt
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/notice/NoticeViewModel.kt
Outdated
Show resolved
Hide resolved
m6z1
force-pushed
the
feature/all-notice-api
branch
from
06f0379
to
52dec17
Compare
huiwoo-jo
approved these changes
Feb 25, 2024
hoyahozz
reviewed
Feb 28, 2024
|
|
||
| NoticeTabType.FACULTY -> viewModelScope.launch { | ||
| when (val result = noticeRepository.fetchDepartmentNotices( | ||
| "컴퓨터소프트웨어공학과", DEFAULT_REFRESH_PAGE |
There was a problem hiding this comment.
네 아직 학과 설정 부분 연결이 되지 않아서 추후에 수정할 예정입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
✍️ 구현 내용
데이터 바인딩을 제거하고뷰바인딩적용했습니다.📷 구현 영상
Screen_recording_20240223_220356.webm
✔️ 확인 사항